dynamic_modules: initial support for attributes#38519
Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom Feb 28, 2025
Merged
dynamic_modules: initial support for attributes#38519mattklein123 merged 5 commits intoenvoyproxy:mainfrom
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Feb 21, 2025
| envoy_dynamic_module_type_attribute_id_XdsUpstreamHostMetadata, | ||
| // xds.filter_chain_name | ||
| envoy_dynamic_module_type_attribute_id_XdsFilterChainName, | ||
| } envoy_dynamic_module_type_attribute_id; |
Member
Author
There was a problem hiding this comment.
note: the choice of enum vs accepting an opaque "path" is intentional as we've experienced in Wasm that paths resolution is unnecessarily complex and slow look up. IIRC Wasm is planning to migrate this enum style from the opaque "get_property([]string)" style.
mathetake
commented
Feb 21, 2025
| * | ||
| * Note: currently, not all attributes are implemented. | ||
| */ | ||
| bool envoy_dynamic_module_callback_http_filter_get_attribute_string( |
Member
Author
There was a problem hiding this comment.
note: just like the existing dynamic metadata callbacks, each function is typed vs opaque "returning some serialized buffer" as we saw in Wasm. Non-integer/string complex type can be supported later (with some non-protobuf serialization scheme) if someone requests.
11 tasks
Member
Author
|
/coverage |
|
Coverage for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/38519/coverage/index.html The coverage results are (re-)rendered each time the CI |
mattklein123
approved these changes
Feb 28, 2025
mathetake
added a commit
to envoyproxy/dynamic-modules-examples
that referenced
this pull request
Mar 1, 2025
envoyproxy/envoy#38519 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
Commit Message: dynamic_modules: initial support for attributes Additional Description: This adds two new callback functions: * envoy_dynamic_module_callback_http_filter_get_attribute_string * envoy_dynamic_module_callback_http_filter_get_attribute_int which are similar to dynamic_metadata callbacks. This implements only a subset of attributes and followup PRs will implement the rest little by little. Risk Level: low Testing: added Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
Commit Message: dynamic_modules: initial support for attributes Additional Description: This adds two new callback functions: * envoy_dynamic_module_callback_http_filter_get_attribute_string * envoy_dynamic_module_callback_http_filter_get_attribute_int which are similar to dynamic_metadata callbacks. This implements only a subset of attributes and followup PRs will implement the rest little by little. Risk Level: low Testing: added Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic_modules: initial support for attributes
Additional Description:
This adds two new callback functions:
which are similar to dynamic_metadata callbacks. This implements only a subset of attributes and followup PRs will implement the rest little by little.
Risk Level: low
Testing: added
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a