Skip to content

dynamic_modules: adds support for header removal#38432

Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mathetake:removeheaders
Feb 15, 2025
Merged

dynamic_modules: adds support for header removal#38432
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mathetake:removeheaders

Conversation

@mathetake
Copy link
Copy Markdown
Member

Commit Message: dynamic_modules: adds support for header removal
Additional Description:

This allows dynamic modules to remove headers/trailers by allowing setter callbacks to accept null pointer values.

Risk Level: low
Testing: done
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38432 was opened by mathetake.

see: more, trace.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake mentioned this pull request Feb 12, 2025
11 tasks
@mathetake mathetake marked this pull request as ready for review February 12, 2025 18:39
@mathetake
Copy link
Copy Markdown
Member Author

/assign @mattklein123

@mattklein123 mattklein123 merged commit eb185a1 into envoyproxy:main Feb 15, 2025
24 checks passed
agrawroh pushed a commit to agrawroh/envoy that referenced this pull request Apr 9, 2025
Commit Message: dynamic_modules: adds support for header removal
Additional Description:

This allows dynamic modules to remove headers/trailers by allowing
setter callbacks to accept null pointer values.

Risk Level: low
Testing: done
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants