Skip to content

docs: adds a release note about dynamic_modules#38334

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
mathetake:releasenotedynamicmodules
Feb 6, 2025
Merged

docs: adds a release note about dynamic_modules#38334
phlax merged 1 commit intoenvoyproxy:mainfrom
mathetake:releasenotedynamicmodules

Conversation

@mathetake
Copy link
Copy Markdown
Member

@mathetake mathetake commented Feb 6, 2025

Commit Message: docs: adds a release note about dynamic_modules
Additional Description:

This is a follow up on #38295

Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@mathetake
docs: adds a release note about dynamic_modules
be95c85 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Feb 6, 2025

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/38334/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #38334 was opened by mathetake.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Feb 6, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38334 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Copy Markdown
Member Author

mathetake commented Feb 6, 2025

/assign @phlax i forgot to add a release note in #38295

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Feb 6, 2025

🙀 Error while processing event:

evaluation error
error: function _rk_error error: path contains forbidden characters:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:135: in _main
  bootstrap:62: in _call
  bootstrap:15: in _call1
  github.com/repokitteh/modules/assign.star:18: in _assign
  github:395: in issue_check_assignee
  github:131: in call
Error: function _rk_error error: path contains forbidden characters
🐱

Caused by: a #38334 (comment) was created by @mathetake.

see: more, trace.

@mathetake
Copy link
Copy Markdown
Member Author

mathetake commented Feb 6, 2025

/assign @phlax

phlax
phlax approved these changes Feb 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mathetake

@mathetake mathetake marked this pull request as ready for review February 6, 2025 18:13
@phlax phlax enabled auto-merge (squash) February 6, 2025 18:13
@phlax phlax disabled auto-merge February 6, 2025 18:13
@phlax phlax enabled auto-merge (squash) February 6, 2025 18:13
@phlax phlax merged commit 3f2d0c2 into envoyproxy:main Feb 6, 2025
24 checks passed
@mathetake mathetake deleted the releasenotedynamicmodules branch February 6, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathetake @phlax