Skip to content

Revert "feature: inbound only graceful draining (#37873)"#38329

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:broken-android
Feb 6, 2025
Merged

Revert "feature: inbound only graceful draining (#37873)"#38329
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:broken-android

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Feb 6, 2025

Fix #38330

@phlax phlax marked this pull request as draft February 6, 2025 12:49
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #38329 was synchronize by phlax.

see: more, trace.

This reverts commit 916594d.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [TESTING/WIP] mobile/ci: Testing broken android Revert "feature: inbound only graceful draining (#37873)" Feb 6, 2025
@phlax phlax marked this pull request as ready for review February 6, 2025 14:54
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax enabled auto-merge (squash) February 6, 2025 15:05
@phlax phlax merged commit 3435d69 into envoyproxy:main Feb 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IntegrationAdminTest.AdminDrainInboundOnlyIdempotent/IPv4_HttpDownstream_HttpUpstreamHttpParserNghttp2Legacy is flakey/broken

3 participants