global rate limit: supported ratelimits in the typed per filter config#37684
Merged
wbpcode merged 41 commits intoenvoyproxy:mainfrom Dec 19, 2024
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
…both for clarity Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
…nd for future extension Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
…er-descriptor-hits-adden-support
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
…er-descriptor-hits-adden-support
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
wbpcode
commented
Dec 16, 2024
Comment on lines
+179
to
+191
| // :ref:`RouteAction.rate_limits<envoy_v3_api_field_config.route.v3.RouteAction.rate_limits>` fields | ||
| // will be ignored. | ||
| // | ||
| // .. note:: | ||
| // Not all configuration fields of | ||
| // :ref:`rate limit config <envoy_v3_api_msg_config.route.v3.RateLimit>` is supported at here. | ||
| // Following fields are not supported: | ||
| // | ||
| // 1. :ref:`rate limit stage <envoy_v3_api_field_config.route.v3.RateLimit.stage>`. | ||
| // 2. :ref:`dynamic metadata <envoy_v3_api_field_config.route.v3.RateLimit.Action.dynamic_metadata>`. | ||
| // 3. :ref:`disable_key <envoy_v3_api_field_config.route.v3.RateLimit.disable_key>`. | ||
| // 4. :ref:`override limit <envoy_v3_api_field_config.route.v3.RateLimit.limit>`. | ||
| repeated config.route.v3.RateLimit rate_limits = 3; |
Member
Author
There was a problem hiding this comment.
This is a break change to the API to avoid the redundant RateLimitConfig message. But this field is never be implemented and is only extension API, so, I think this should be fine. cc @envoyproxy/api-shepherds
Member
There was a problem hiding this comment.
If never implemented sounds good.
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
…lobal-ratelimit-support-per-descriptor
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
|
/wait #37548 |
added 2 commits
December 18, 2024 12:08
…into dev-global-ratelimit-support-per-descriptor
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
added 2 commits
December 18, 2024 15:03
…lobal-ratelimit-support-per-descriptor
Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
Member
Author
…lobal-ratelimit-support-per-descriptor
Member
Author
|
/retest |
mattklein123
approved these changes
Dec 19, 2024
This was referenced Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: global rate limit: support per descriptor custom hits addend
Additional Description:
rate_limitsin theRateLimitPerRoute. Now, we can configure the global rate limit filter in thetype_per_filter_configof route.rate_limitsin theRateLimitPerRoutefor now).Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.