Add load_assignment field in Cluster#3504
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Jun 6, 2018
dio:cluster-api-load-assignment
Merged
Add load_assignment field in Cluster#3504htuch merged 4 commits intoenvoyproxy:masterfrom dio:cluster-api-load-assignment
htuch merged 4 commits intoenvoyproxy:masterfrom
dio:cluster-api-load-assignment
Conversation
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
zuercher
reviewed
May 30, 2018
| // Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values. | ||
| // | ||
| // [#not-implemented-hide:] | ||
| ClusterLoadAssignment load_assignment = 33; |
Member
There was a problem hiding this comment.
I think the discussion at https://github.com/envoyproxy/envoy/pull/3261/files#r188243657 still applies.
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
mattklein123
reviewed
Jun 5, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, small comment nit.
| // | ||
| // Setting this allows CDS static/DNS assignments to contain embedded EDS equivalent | ||
| // :ref:`endpoint assignments<envoy_api_msg_ClusterLoadAssignment>`. | ||
| // Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values. |
Member
There was a problem hiding this comment.
@dio can you make a note to deprecate the hosts field and add to deprecated.md when you do the PR implementing this?
Member
Author
There was a problem hiding this comment.
Sure, 2ab4f13. Thanks for reminding me.
api/envoy/api/v2/cds.proto
Outdated
| // | ||
| // .. attention:: | ||
| // | ||
| // Setting this allows CDS static/DNS assignments to contain embedded EDS equivalent |
Member
There was a problem hiding this comment.
"CDS static/DNS" is a bit confusing to read. Can you rephrase? Do you mean "Setting this allows non-EDS cluster types to contain..." ?
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
zuercher
approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
load_assignmentfield in ClusterThis patch introduces
load_assigmentfield in CDS' Cluster. This is an API change only.This is part of effort on breaking #3261 into multiple PRs.
Risk Level:
Testing:
Docs Changes:
Signed-off-by: Dhi Aurrahman dio@rockybars.com