fine_grain_logger: make sure fine-grain-logger map registration in macros#34815
Merged
ggreenway merged 5 commits intoenvoyproxy:mainfrom Jun 24, 2024
Merged
fine_grain_logger: make sure fine-grain-logger map registration in macros#34815ggreenway merged 5 commits intoenvoyproxy:mainfrom
ggreenway merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Boteng Yao <boteng@google.com>
Member
Author
|
/retest |
Member
Author
|
/assign @KBaichoo |
Member
Author
|
/wait |
Signed-off-by: Boteng Yao <boteng@google.com>
Member
Author
|
/retest |
Member
Author
|
Hi @KBaichoo, this is ready for a review. Thanks! |
Signed-off-by: Boteng Yao <boteng@google.com>
KBaichoo
previously approved these changes
Jun 24, 2024
Contributor
KBaichoo
left a comment
There was a problem hiding this comment.
lgtm apart from minor change
Signed-off-by: Boteng Yao <boteng@google.com>
Member
Author
|
/assign @ggreenway |
KBaichoo
approved these changes
Jun 24, 2024
ggreenway
approved these changes
Jun 24, 2024
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…cros (envoyproxy#34815) Signed-off-by: Boteng Yao <boteng@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…cros (envoyproxy#34815) Signed-off-by: Boteng Yao <boteng@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…cros (envoyproxy#34815) Signed-off-by: Boteng Yao <boteng@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…cros (envoyproxy#34815) Signed-off-by: Boteng Yao <boteng@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 21, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Dec 3, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Dec 11, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Dec 17, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Dec 18, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ENVOY_LOG_COMP_LEVELwill lead to non-active fine-grain loggers are not managed by the fine-grain logger map when log level is lower than default, sinceENVOY_LOG_TO_LOGGERis the only way to callFINE_GRAIN_LOGto initialize a fg-logger.This PR creates a new
FINE_GRAIN_LOGGER()and that can be used for getting fine-grain logger.Also creates a new
ENVOY_LOG_COMP_LEVEL_FINE_GRAIN_IF()to consider fine-grain logger when doing comparison.Note, not all marcos are migrated.
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]