stats: new thread local store implementation#348
Merged
mattklein123 merged 8 commits intomasterfrom Jan 17, 2017
Merged
Conversation
This is needed to support dynamic add/remove of clusters and
transitively stat scopes.
There is no way around the fact that this is an extremely complicated
change. See the comment in thread_local_store.h for more info.
NOTE: This changes the shared memory layout and will require a full
restart.
Member
Author
|
@lyft/network-team this is a very risky change. I don't plan on shipping till next week and will do some smoke testing so there is time to do a thorough review. |
Member
Author
|
quick note: I think shutdown is not quite correct. There is a way that we will run runOnAllThreads() while/after workers have shutdown. Will look at this more tomorrow. |
Member
|
@mattklein123 what do you mean by requiring full restart? Are you referring to your existing envoy deployments? |
Member
Author
|
@rshriram this PR changes the shared memory layout so that the stats can be reference counted. Hot restart is not possible and a full restart is required for deployment. This is not a common occurrence. I think the last time this happened was about a year ago. |
Member
Author
|
@lyft/network-team I'm smoke testing this now and it looks good so far so I think ready for review. |
ccaraman
reviewed
Jan 12, 2017
| * with the same address, and a cache flush operation could race and delete cache data | ||
| * for the new scope. This is extremely unlikely, and if it happens the cache will be | ||
| * repopulated on the next access. | ||
| * - Since it's possibly to have overlapping scopes, we de-dup stats when counters() or gauges() |
RomanDzhabarov
approved these changes
Jan 17, 2017
mattklein123
added a commit
that referenced
this pull request
Jan 17, 2017
The stats change in #348 does not actually change the size of the shared memory region due to compiler alignment (at least on gcc 4.9). This will force a shared memory region version bump.
mattklein123
added a commit
that referenced
this pull request
Jan 17, 2017
The stats change in #348 does not actually change the size of the shared memory region due to compiler alignment (at least on gcc 4.9). This will force a shared memory region version bump.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Added PendingCheckCallbacks to ApiManager * Fixed code formatting * Fixed code formatting * Pending Report checks pending Check callback status, Fixed pending callback list clear bug * Renamed methods and variables. Added IsConfigLoadingDone to ApiManager * Added error handling of ApiManager initialization failure * Removed pending_request_callback_exist_ flag and added error handling * Removed pending_request_callback_exist_ flag from header * CreateRequestContext() returns bool * Fixed incorrect return value * Fixed bugs
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Add envoy configuration which exposes our default configuration yaml Create an envoy builder class which helps with ergonomically creating an envoy instance to be run Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: Add envoy config and envoy builder Risk Level: low Testing: unit Docs Changes: none Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Add envoy configuration which exposes our default configuration yaml Create an envoy builder class which helps with ergonomically creating an envoy instance to be run Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: android: Add envoy config and envoy builder Risk Level: low Testing: unit Docs Changes: none Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This commit adds documentation for using the DeepSeek R1 model (running locally considering Platform Keys are not available) with Envoy AI Proxy. **Related Issues/PRs (if applicable)** Supersedes #287 --------- Signed-off-by: Eric Mariasis <ericmariasis829@gmail.com> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com> Co-authored-by: Erica Hughberg <erica.sundberg.90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to support dynamic add/remove of clusters and
transitively stat scopes.
There is no way around the fact that this is an extremely complicated
change. See the comment in thread_local_store.h for more info.
NOTE: This changes the shared memory layout and will require a full
restart.