Replace openssl with boringssl as the official ssl provider#339
Merged
mattklein123 merged 3 commits intomasterfrom Jan 10, 2017
Merged
Replace openssl with boringssl as the official ssl provider#339mattklein123 merged 3 commits intomasterfrom
mattklein123 merged 3 commits intomasterfrom
Conversation
PiotrSikora
reviewed
Jan 10, 2017
| cd .. | ||
| rm -fr libevent* | ||
|
|
||
| # boring ssl |
PiotrSikora
reviewed
Jan 10, 2017
| git clone https://boringssl.googlesource.com/boringssl | ||
| cd boringssl | ||
| git reset --hard 78684e5b222645828ca302e56b40b9daff2b2d27 | ||
| cmake -DCMAKE_INSTALL_PREFIX:PATH=$THIRDPARTY_BUILD . |
Contributor
There was a problem hiding this comment.
BoringSSL doesn't provide make install target, so -DCMAKE_INSTALL_PREFIX:PATH=$THIRDPARTY_BUILD is useless and can be removed.
Member
Author
There was a problem hiding this comment.
right, i was playing around it and forgot to remove...
Member
|
Does this work without any other code changes? Or do we also need other commits to change paths? |
Contributor
|
Commit message could use a bit more text ;) |
Member
|
If there are no other code changes required, can you also update docs in this commit about third party dependencies. (You should mention in docs that we build against boringssl but that openssl should still work). @roman: no code changes required, all builds fine. Will update docs. |
Member
Author
|
new image is pushed to docker hub |
mattklein123
approved these changes
Jan 10, 2017
enricoschiattarella
pushed a commit
to enricoschiattarella/envoy
that referenced
this pull request
Jan 10, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This will be helpful in debugging connectivity especially. Now you can spawn `envoy -c ./tests/extproc/envoy.yaml` and open `localhost:9901` on your browser to debug the connectivity. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @lyft/network-team @PiotrSikora