Merged
Conversation
Currently stats are allocated from a fix memory pool in shared memory so that we can do hot restart. We have no facility to delete stats. This is not going to work when we can add/remove clusters dynamically. This commit adds a new scope concept and plumbs through a scope for all cluster stats. The actual scope implementation doesn't do anything currently other than just pass through to the main store. The actual shared memory implementation of deletion is quite complicated so I will do that in a dedicated smaller change. A few other notes: 1) I got rid of alt_stat_prefix from cluster. This was used a long time ago when we were rolling out sds. It's hard to support in the new scheme so I'm just getting rid of it. 2) How we manage SSL contexts is also broken for cluster deletion. The contexts are currently global and not deleted. I will fix this in a follow up.
Member
Author
|
@lyft/network-team please review. Sorry for another really large change. This is pretty straightforward though. I will do all of the more complicated shared memory deletion stuff in a different commit. |
ccaraman
approved these changes
Jan 9, 2017
mattklein123
added a commit
that referenced
this pull request
Jan 10, 2017
Regresion from #334. I'm in the process of rewriting all of the scope stuff currently so I'm not going to bother with tests. I will add tests in the real change.
mattklein123
added a commit
that referenced
this pull request
Jan 10, 2017
Regresion from #334. I'm in the process of rewriting all of the scope stuff currently so I'm not going to bother with tests. I will add tests in the real change.
enricoschiattarella
pushed a commit
to enricoschiattarella/envoy
that referenced
this pull request
Jan 10, 2017
Regresion from envoyproxy#334. I'm in the process of rewriting all of the scope stuff currently so I'm not going to bother with tests. I will add tests in the real change.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
lambdai
pushed a commit
to lambdai/envoy-dai
that referenced
this pull request
Jun 12, 2022
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** extproc: remove the path from the translator factory Removes the path from the translator factory, now that there is a dedicated processor for the chat completion endpoint. **Related Issues/PRs (if applicable)** Follow-up for: envoyproxy/ai-gateway#325 (review) **Special notes for reviewers (if applicable)** Note that I don't remove the `Factory` type completely so that only the right translator is instantiated and only when needed. --------- Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently stats are allocated from a fix memory pool in shared memory
so that we can do hot restart. We have no facility to delete stats. This
is not going to work when we can add/remove clusters dynamically. This
commit adds a new scope concept and plumbs through a scope for all cluster
stats. The actual scope implementation doesn't do anything currently other
than just pass through to the main store. The actual shared memory
implementation of deletion is quite complicated so I will do that in a
dedicated smaller change.
A few other notes:
when we were rolling out sds. It's hard to support in the new scheme so
I'm just getting rid of it.
are currently global and not deleted. I will fix this in a follow up.