Stringmatcher: cleanup temporary code#33072
Merged
ggreenway merged 3 commits intoenvoyproxy:mainfrom Mar 22, 2024
Merged
Conversation
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Member
Author
|
After this, I'll do a rename of |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Looks like the stringmatcher/lua path was the only thing covering some lines Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Member
Author
|
For coverage, looks like stringmatcher/lua was the only thing covering some lines. This was bumped after the stringmatcher code was added in #32822; so this is bumping back down just this one file. |
This was referenced Mar 22, 2024
RyanTheOptimist
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Removes temporary extra classes, and moves to a better way to handle string matcher extension factories
Additional Description:
Risk Level: Low
Fixes #32792
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]