Skip to content

Support forwarding username to backends#32943

Merged
htuch merged 11 commits intoenvoyproxy:mainfrom
zhaohuabing:basic-auth-extract-username
Mar 28, 2024
Merged

Support forwarding username to backends#32943
htuch merged 11 commits intoenvoyproxy:mainfrom
zhaohuabing:basic-auth-extract-username

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

Related to #32419

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #32943 was opened by zhaohuabing.

see: more, trace.

@zhaohuabing zhaohuabing marked this pull request as draft March 17, 2024 02:47
@zhaohuabing zhaohuabing force-pushed the basic-auth-extract-username branch 2 times, most recently from 7081e83 to 4fa27ad Compare March 17, 2024 03:24
@zhaohuabing zhaohuabing force-pushed the basic-auth-extract-username branch 10 times, most recently from 019b115 to 86b0233 Compare March 17, 2024 09:26
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the basic-auth-extract-username branch from 86b0233 to a91d664 Compare March 17, 2024 09:54
@zhaohuabing zhaohuabing marked this pull request as ready for review March 17, 2024 09:54
@zhaohuabing zhaohuabing requested a review from wbpcode as a code owner March 17, 2024 09:54
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member Author

/retest

@zhaohuabing zhaohuabing requested a review from htuch March 19, 2024 09:59
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@yanavlasov
Copy link
Copy Markdown
Contributor

Pinging @htuch for final review.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 34d67fc into envoyproxy:main Mar 28, 2024
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
Related to envoyproxy#32419

Risk level: Low
Testing: Unit/integration tests.

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing deleted the basic-auth-extract-username branch January 21, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants