Revert "Begin process of removing singleton use by StringMatcher (#32…#32902
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Mar 14, 2024
Merged
Revert "Begin process of removing singleton use by StringMatcher (#32…#32902phlax merged 1 commit intoenvoyproxy:mainfrom
phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
…oyproxy#32829)" This reverts commit b7818b0. Signed-off-by: Ryan Northey <ryan@synca.io>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Member
Author
|
@ggreenway this seems to have created a permafailing TIMEOUT in the rbac tests (maybe others) |
Member
Author
|
this is the error: TIMEOUT: @envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test (Summary)
/build/bazel_root/base/execroot/envoy_filter_example/bazel-out/k8-fastbuild/testlogs/external/envoy/test/extensions/filters/http/rbac/rbac_filter_integration_test/shard_1_of_2/test.log
INFO: From Testing @envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test (shard 1 of 2):
stdout (/build/bazel_root/base/execroot/envoy_filter_example/bazel-out/_tmp/actions/stdout-25444) 1693776 exceeds maximum size of --experimental_ui_max_stdouterr_bytes=1048576 bytes; skipping
INFO: Elapsed time: 2363.025s, Critical Path: 998.12s
INFO: 19385 processes: 6112 remote cache hit, 8517 internal, 4756 remote.
@envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test TIMEOUT in 1 out of 2 in 902.3s
Stats over 2 runs: max = 902.3s, min = 811.2s, avg = 856.8s, dev = 45.5s
WARNING: @envoy//test/extensions/filters/http/rbac:rbac_filter_integration_test: Test execution time (811.2s excluding execution overhead) outside of range for LONG tests. Consider setting timeout="eternal" or size="enormous".
/build/bazel_root/base/execroot/envoy_filter_example/bazel-out/k8-fastbuild/testlogs/external/envoy/test/extensions/filters/http/rbac/rbac_filter_integration_test/shard_1_of_2/test.log
Executed 1148 out of 1148 tests: 1147 tests pass and 1 fails remotely.
INFO: Streaming build results to: https://source.cloud.google.com/results/invocations/481c1d87-2517-4e08-bd76-3759c5fa1888
~/envoy-filter-example/bazel-testlogs ~/envoy-filter-example
~/envoy-filter-example |
alyssawilk
approved these changes
Mar 14, 2024
Member
Author
|
pushing this past windows lag to fix CI |
ggreenway
added a commit
to ggreenway/envoy
that referenced
this pull request
Mar 14, 2024
…her (envoyproxy#32… (envoyproxy#32902)" This reverts commit 9ac0dd8. Signed-off-by: Greg Greenway <ggreenway@apple.com>
phlax
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Revert "Revert "Begin process of removing singleton use by StringMatcher (#32… (#32902)" This reverts commit 9ac0dd8. Signed-off-by: Greg Greenway <ggreenway@apple.com> * try increasing shard count to attempt fix of test timeout Signed-off-by: Greg Greenway <ggreenway@apple.com> --------- Signed-off-by: Greg Greenway <ggreenway@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…829)"
This reverts commit b7818b0.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]