Skip to content

opentelemetrytracer: Dynatrace sampler: Enable adaptative sampling#32848

Merged
wbpcode merged 6 commits intoenvoyproxy:mainfrom
dynatrace-oss-contrib:feat/dt-sampler-poll-config
Mar 21, 2024
Merged

opentelemetrytracer: Dynatrace sampler: Enable adaptative sampling#32848
wbpcode merged 6 commits intoenvoyproxy:mainfrom
dynatrace-oss-contrib:feat/dt-sampler-poll-config

Conversation

@samohte
Copy link
Copy Markdown
Contributor

@samohte samohte commented Mar 12, 2024

Commit Message: Dynatrace sampler to fetch configuration from an API

Additional Description: In #32598 a custom Dynatrace sampler was added to Envoy. This sampler should now be extended to fetch its configuration via an HTTP call from a Dyantrace cluster.
Testing: Unit, Integration, Manual
Docs Changes: N/A
Release Notes:Dynatrace sampler to fetch configuration from an API
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@samohte @joaopgrassi
opentelemetrytracer: Dynatrace sampler to fetch configuration from an…
824b0f9 
… API (#21)

* Dynatrace sampler to fetch configuration from an API

Signed-off-by: Thomas Ebner <96168670+samohte@users.noreply.github.com>
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 12, 2024

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32848 was opened by samohte.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 12, 2024

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #32848 was opened by samohte.

see: more, trace.

@samohte
Merge remote-tracking branch 'upstream/main' into feat/dt-sampler-pol…
1a15396 
…l-config

Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
@samohte samohte changed the title opentelemetrytracer: Dynatrace sampler to fetch configuration from an… opentelemetrytracer: Dynatrace sampler: Enable adaptative sampling Mar 12, 2024
@samohte
Merge remote-tracking branch 'upstream/main' into feat/dt-sampler-pol…
36249ae 
…l-config

Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
@samohte samohte marked this pull request as ready for review March 12, 2024 18:49
@samohte samohte requested a review from htuch as a code owner March 12, 2024 18:49
@samohte
Merge remote-tracking branch 'upstream/main' into feat/dt-sampler-pol…
4c246a6 
…l-config

Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
wbpcode
wbpcode reviewed Mar 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution. And some comments are added. :)

@wbpcode
Copy link
Copy Markdown
Member

wbpcode commented Mar 17, 2024

/lgtm api

@wbpcode
Copy link
Copy Markdown
Member

wbpcode commented Mar 17, 2024

/wait

@samohte
review feedback: add log msg, remove timeout adjustment
535d99b 
Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
@samohte
Copy link
Copy Markdown
Contributor Author

samohte commented Mar 18, 2024

Thanks for you contribution. And some comments are added. :)

Thanks for your valuable feedback. I addressed your comments in 535d99b

wbpcode
wbpcode requested changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you in timely update. Now, LGTM overall except the last comment about the thread safe. And please resolve the conflict. Thanks.

@samohte
Merge remote-tracking branch 'upstream/main' into feat/dt-sampler-pol…
05bd952 
…l-config

Signed-off-by: thomas.ebner <thomas.ebner@dynatrace.com>
@samohte
Copy link
Copy Markdown
Contributor Author

samohte commented Mar 19, 2024

Thanks for you in timely update. Now, LGTM overall except the last comment about the thread safe. And please resolve the conflict. Thanks.

I have resolved the conflict and answered your comment. Pls. let me know what you think about.

@samohte
Copy link
Copy Markdown
Contributor Author

samohte commented Mar 19, 2024

/retest

@samohte samohte requested a review from wbpcode March 20, 2024 09:16
@wbpcode wbpcode merged commit c4fe01c into envoyproxy:main Mar 21, 2024
@samohte samohte deleted the feat/dt-sampler-poll-config branch March 21, 2024 06:03
This was referenced Mar 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbpcode wbpcode wbpcode approved these changes

@htuch htuch Awaiting requested review from htuch

Assignees

@wbpcode wbpcode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samohte @wbpcode