http3: fixing an upstream threading issue and bumping http3 upstream code back to alpha#32640
Merged
alyssawilk merged 5 commits intoenvoyproxy:mainfrom Mar 4, 2024
Merged
http3: fixing an upstream threading issue and bumping http3 upstream code back to alpha#32640alyssawilk merged 5 commits intoenvoyproxy:mainfrom
alyssawilk merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ggreenway
previously approved these changes
Feb 29, 2024
Member
ggreenway
left a comment
There was a problem hiding this comment.
Specifically approving the change in stability status of the feature
ggreenway
reviewed
Feb 29, 2024
|
|
||
| HTTP/3 **upstream support is fine for locally controlled networks**, but is alpha for | ||
| general internet use - key features are implemented but have not been tested at scale. | ||
| HTTP/3 support is alpha - key features are implemented but have not been tested at scale. |
Member
There was a problem hiding this comment.
Suggested change
| HTTP/3 support is alpha - key features are implemented but have not been tested at scale. | |
| HTTP/3 upstream support is alpha - key features are implemented but have not been tested at scale. |
Contributor
Author
|
/wait on CI (looks like I missed some test mocks) |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
RyanTheOptimist
approved these changes
Feb 29, 2024
mattjo
added a commit
to mattjo/envoy
that referenced
this pull request
Mar 5, 2024
* main: (151 commits) http3: fixing an upstream threading issue and bumping http3 upstream code back to alpha (envoyproxy#32640) rlqs: reset quota usage (envoyproxy#32569) proxy status: add more mapping to proxystatus (envoyproxy#32606) rlqs: add logging around token bucket (envoyproxy#32612) Logging: ENVOY_BUG include filter name. (envoyproxy#32663) mobile: Reenable the FilterIntegrationTest.AltSvcCachedH2Slow test (envoyproxy#32675) c++20 by default (envoyproxy#32585) Docs: Add diagram for histogram stat sink. (envoyproxy#32665) Fix null node for list of struct in payload_to_metadaata filter (envoyproxy#32309) metrics_service: populate histogram summary sample sum (envoyproxy#32666) build(deps): bump postgres from `0e564da` to `f58300a` in /examples/shared/postgres (envoyproxy#32632) build(deps): bump the examples-ext-authz group in /examples/ext_authz with 1 update (envoyproxy#32654) build(deps): bump distroless/base-nossl-debian12 from `28dc895` to `0e777c6` in /ci (envoyproxy#32652) Update QUICHE from 02047e04d to 3373df94b (envoyproxy#32650) ci/logging: Add failure detection (envoyproxy#32662) Change udpa renaming workaround to not compile the same archive twice (envoyproxy#32647) sockets: flipping graceful client socket creation failure (envoyproxy#32602) TcpAsyncClient: enhance reconnect robustness (envoyproxy#32578) owners: adding Fredy as an Enovy Mobile maintainer (envoyproxy#32638) ci: Add scheduled garbage collection (and fix retest) (envoyproxy#32639) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy as a community is not in the habit of moving "GA" code to alpha. It was believed at the time that HTTP/3 upstream code had been deployed successfully in production but based on the severity of the bug fixed here it appears that was not the case. Changing security status to reflect the current perceived code stability.
Risk Level: low
Testing: e2e test
Docs Changes: inline
Release Notes: inline