Fix errors during docker-compose for grpc-bridge#325
Closed
drobertduke wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
Fix errors during docker-compose for grpc-bridge#325drobertduke wants to merge 1 commit intoenvoyproxy:masterfrom
drobertduke wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
drobertduke
commented
Jan 5, 2017
- Update apt so python-dev deb will install without error
- Fix the path to the service code in the COPY command
- Remove a failing reference to RESPONSE_FLAGS in the log format
- Update apt so python-dev deb will install without error - Fix the path to the service code in the COPY command - Remove a failing reference to RESPONSE_FLAGS in the log format
Author
mattklein123
reviewed
Jan 5, 2017
| { | ||
| "path": "/var/log/envoy/egress_http.log", | ||
| "format": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH):256% %PROTOCOL%\" %RESPONSE_CODE% %RESPONSE_FLAGS% %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\"\n" | ||
| "format": "[%START_TIME%] \"%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH):256% %PROTOCOL%\" %RESPONSE_CODE% %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% \"%REQ(X-FORWARDED-FOR)%\" \"%REQ(USER-AGENT)%\" \"%REQ(X-REQUEST-ID)%\" \"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\"\n" |
Member
There was a problem hiding this comment.
This should work, the issue is an older binary. Sorry this whole situation is a mess. We will get this fixed properly soon.
Member
There was a problem hiding this comment.
+1 that access log format string should work fine: https://github.com/lyft/envoy/blob/87953d16007284bbd3f7a8fc3cfe7b50cd2cf309/source/common/http/access_log/access_log_formatter.cc#L255
Member
|
cc @junr03 |
drobertduke
commented
Jan 5, 2017
| FROM lyft/envoy:latest | ||
|
|
||
| RUN mkdir /var/log/envoy/ | ||
| COPY ./bin/service /usr/local/bin/srv |
Author
There was a problem hiding this comment.
At the end of the example there are instructions for building the go service which creates a bin/service binary. Is this COPY line supposed to copy the result of that? If so the order of the tutorial should be changed.
https://lyft.github.io/envoy/docs/install/sandboxes.html#building-the-go-service
Member
|
I'm going to go ahead and close this. We will fix this all up when we automate the docker builds. ETA probably 2-3 weeks. @junr03 is on vacation. |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
yxue
pushed a commit
to yxue/envoy
that referenced
this pull request
Dec 3, 2019
Signed-off-by: Yaroslav Skopets <y.skopets@gmail.com>
liverbirdkte
referenced
this pull request
in liverbirdkte/envoy
Nov 17, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Makes some relatively minor updates to match up with the JNI interfaces being checked in with envoyproxy/envoy-mobile#326. This diff was larger before, but much of it got checked in with envoyproxy/envoy-mobile#329. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Makes some relatively minor updates to match up with the JNI interfaces being checked in with envoyproxy/envoy-mobile#326. This diff was larger before, but much of it got checked in with envoyproxy/envoy-mobile#329. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** extproc: custom processors per path and serve /v1/models Refactors the server processing to allow registering custom Processors for different request paths, and adds a custom processor for requests to `/v1/models` that returns an immediate response based on the models that are configured in the filter configuration. **Related Issues/PRs (if applicable)** Related discussion: envoyproxy/ai-gateway#186 --------- Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This removes the unnecessary suffix "Iface" from extproc.ProcessorIface interface. **Related Issues/PRs (if applicable)** Follow up on #325 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** After #325, the translator is not where the abstraction over :path is implemented, but it moved to the choice of processor. As a result, the translator interface has become effectively tied to a specific endpoint, notably /v1/chat/completion. This renames the `translator.Translator` interface accordingly not only to remove the unnecessary code path but also facilitates the implementation of additional features like metrics. **Related Issues/PRs (if applicable)** Follow up on #325 and contribute to #316 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Previously, /v1/models endpoint returned all header matching values, not limited to the special "x-ai-eg-model" header. This fixes it, and only lists the values from the matching rules using that header. **Related Issues/PRs (if applicable)** Follow up on #325 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.