Skip to content

xDS rate-limit: rejecting inf and nan fill rate values#32203

Merged
htuch merged 4 commits intoenvoyproxy:mainfrom
adisuissa:fuzz_bug_66327
Feb 16, 2024
Merged

xDS rate-limit: rejecting inf and nan fill rate values#32203
htuch merged 4 commits intoenvoyproxy:mainfrom
adisuissa:fuzz_bug_66327

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

Commit Message: xDS rate-limit: rejecting inf and nan fill rate values
Additional Description:
Rejecting a config with invalid Inf or NaN values for the fill-rate of the xDS streams.

Risk Level: low
Testing: Added unit tests and fuzz corpus
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Fixes fuzz bug 66327

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa
Copy link
Copy Markdown
Contributor Author

/retest

@kyessenov
Copy link
Copy Markdown
Contributor

Needs main merge.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit ab2bf64 into envoyproxy:main Feb 16, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 3, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 3, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 3, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 4, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 4, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 17, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 17, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 17, 2024
sayboras added a commit to cilium/proxy that referenced this pull request Jul 23, 2024
github-merge-queue bot pushed a commit to cilium/proxy that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants