Revert "http/2: better handling for messaging error resets (#3140)"#3213
Merged
mattklein123 merged 1 commit intomasterfrom Apr 25, 2018
Merged
Revert "http/2: better handling for messaging error resets (#3140)"#3213mattklein123 merged 1 commit intomasterfrom
mattklein123 merged 1 commit intomasterfrom
Conversation
This reverts commit e293ffb. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
We believe (but aren't sure) that this change is causing production canary crashes at Lyft. I have a vague idea that it might be due to reset propagation not working correctly in cases where we would have previously closed the connection. Going to try a revert to verify then will think about this more. |
Member
Author
ccaraman
approved these changes
Apr 25, 2018
Member
Author
|
This change is not the issue. Still seeing crashes with it reverted. Will reapply and keep poking around tomorrow. Given the diff that was deployed it's not clear what the issue is. |
mattklein123
added a commit
that referenced
this pull request
Apr 26, 2018
mattklein123
added a commit
that referenced
this pull request
Apr 26, 2018
ramaraochavali
pushed a commit
to ramaraochavali/envoy
that referenced
this pull request
May 3, 2018
…y#3140)" (envoyproxy#3213) This reverts commit e293ffb. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Rama <rama.rao@salesforce.com>
ramaraochavali
pushed a commit
to ramaraochavali/envoy
that referenced
this pull request
May 3, 2018
…nvoyproxy#3140)" (envoyproxy#3213)" (envoyproxy#3233) This reverts commit 3b4badd. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Rama <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e293ffb.