build: Fix ASAN build with --define=google_grpc=disabled#3211
Merged
ggreenway merged 1 commit intoenvoyproxy:masterfrom Apr 25, 2018
Merged
build: Fix ASAN build with --define=google_grpc=disabled#3211ggreenway merged 1 commit intoenvoyproxy:masterfrom
ggreenway merged 1 commit intoenvoyproxy:masterfrom
Conversation
ASAN does not allow *(nullptr) being converted to a reference. Fixes envoyproxy#3208 Signed-off-by: Greg Greenway <ggreenway@apple.com>
mattklein123
approved these changes
Apr 25, 2018
htuch
approved these changes
Apr 25, 2018
ramaraochavali
pushed a commit
to ramaraochavali/envoy
that referenced
this pull request
May 3, 2018
ASAN does not allow *(nullptr) being converted to a reference. Fixes envoyproxy#3208 Signed-off-by: Greg Greenway <ggreenway@apple.com> Signed-off-by: Rama <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASAN does not allow *(nullptr) being converted to a reference.
Fixes #3208
Signed-off-by: Greg Greenway ggreenway@apple.com
Risk Level: Low
Testing: Built ASAN with --define=google_grpc=disabled