Rename SharedMemoryHashSet to BlockMemoryHashSet#3150
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 20, 2018
Merged
Conversation
Signed-off-by: James Buckland <jbuckland@google.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
Seems fine to me. Small comment/nit.
|
|
||
| /** | ||
| * Initialization parameters for SharedMemoryHashSet. The options are duplicated | ||
| * Initialization parameters for BlockMemoryHashSet. The options are duplicated |
Member
There was a problem hiding this comment.
Can you search this file for "shared" as well as the cc file? I think there are some comments that need to be fixed in a similar way...
Contributor
Author
There was a problem hiding this comment.
Thanks, I think I caught them in c03b486.
Signed-off-by: James Buckland <jbuckland@google.com>
source/server/hot_restart_impl.cc
Outdated
|
|
||
| int flags = O_RDWR; | ||
| const std::string shmem_name = fmt::format("/envoy_shared_memory_{}", options.baseId()); | ||
| const std::string shmem_name = fmt::format("/envoy_block_memory_{}", options.baseId()); |
Member
There was a problem hiding this comment.
I think this one should be reverted. a) it is shared memory. b) it's possible people have setup permissions to allow this exact path. I see no reason to change it...
Contributor
Author
There was a problem hiding this comment.
Good catch, I'll swap this back.
Signed-off-by: James Buckland <jbuckland@google.com>
mattklein123
approved these changes
Apr 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Buckland jbuckland@google.com
Title: Rename SharedMemoryHashSet to BlockMemoryHashSet
Description: The class currently named SharedMemoryHashSet has no specific bias towards shared or non-shared memory, instead accepts a pointer to the buffer in memory for the set data.
For context, a solution for #2453 could use this hash set to implement reference counting across scopes. It would not necessarily need to run in shared memory.
Risk Level: Low
Testing: N/A - no behavior change.
Docs Changes: N/A, this is not user-facing.
Release Notes: N/A