Skip to content

!ENVOY_HOT_RESTART does not reference count across scopes #2453

@htuch

Description

@htuch

From code inspection, I suspect that when we disable hot restart, two distinct stats scopes will not share underlying counter allocations for same name counters, e.g. "foo.bar" in scope A will not alias "foo.bar" in scope B. This is because when !ENVOY_HOT_RESTART we use Stats::HeapRawStatDataAllocator (

Stats::HeapRawStatDataAllocator stats_allocator;
), which doesn't reference count (see https://github.com/envoyproxy/envoy/blob/master/source/common/stats/stats_impl.cc#L183).

This issue need to be first verified and if necessary we need to switch to a reference count backed allocator for !ENVOY_HOT_RESTART builds.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions