-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
Description
From code inspection, I suspect that when we disable hot restart, two distinct stats scopes will not share underlying counter allocations for same name counters, e.g. "foo.bar" in scope A will not alias "foo.bar" in scope B. This is because when !ENVOY_HOT_RESTART we use Stats::HeapRawStatDataAllocator (
envoy/source/exe/main_common.cc
Line 65 in dceb8cb
| Stats::HeapRawStatDataAllocator stats_allocator; |
This issue need to be first verified and if necessary we need to switch to a reference count backed allocator for !ENVOY_HOT_RESTART builds.
Reactions are currently unavailable