Skip to content

admin: apply flow control via high/low watermarks#31087

Closed
jmarantz wants to merge 6 commits intoenvoyproxy:mainfrom
jmarantz:admin-flow-control2
Closed

admin: apply flow control via high/low watermarks#31087
jmarantz wants to merge 6 commits intoenvoyproxy:mainfrom
jmarantz:admin-flow-control2

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz commented Nov 28, 2023

Commit Message: This builds on #19831 , adding an attempt to use http filter methods to deploy flow-control, so we can pause generation of admin output until clients are ready for it.

This is not ready yet -- @alyssawilk has explained to me how to get the flow-control to work

  • use high-watermark callback to set a bit in the filter to avoid sending more data
  • use low-watermark callback to clear the above bit and send another chunk, and then queue up a callback for the next chunk (assuming high-water callback is not called).

This pattern should also be in the http cache filter and also the Router, though the latter is a lot more complex.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

jmarantz added 5 commits May 8, 2022 17:34
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #31087 was opened by jmarantz.

see: more, trace.

@jmarantz
Copy link
Copy Markdown
Contributor Author

This PR replaces #19898 which got too stale.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 31, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2024

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 7, 2024
@jmarantz jmarantz reopened this Feb 21, 2024
@jmarantz jmarantz added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Feb 21, 2024
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no stalebot Disables stalebot from closing an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants