Make 100% test coverage for upstream_impl.cc#302
Merged
RomanDzhabarov merged 3 commits intomasterfrom Dec 17, 2016
Merged
Conversation
Conflicts: test/common/upstream/sds_test.cc
mattklein123
approved these changes
Dec 17, 2016
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
liverbirdkte
referenced
this pull request
in liverbirdkte/envoy
Sep 21, 2022
Signed-off-by: LeiZhang <lei.a.zhang@intel.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Jun 3, 2025
Sidecar ext authz can fail if the instance is paused or readable secondaries has been disabled because we will remove the hostname from mercury config and thus ext_authz call will fail. Update error msg to reflect this.
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Add helm install. **Related Issues/PRs (if applicable)** Fixes #302 --------- Signed-off-by: Loong <long0dai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover two important cases with max_host_weight.