Merged
Conversation
test/integration/fake_upstream.h
Outdated
| @@ -51,6 +53,7 @@ class FakeStream : public Http::StreamDecoder, public Http::StreamCallbacks { | |||
| Http::HeaderMapPtr trailers_; | |||
| bool end_stream_{}; | |||
| uint64_t body_length_{}; | |||
Member
There was a problem hiding this comment.
can we remove body_length_ and just use body_.length() ?
mattklein123
approved these changes
Dec 15, 2016
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* add service context map * Rename operator+= to Merge * Check return of GetStatistics * add service_name check.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Nov 25, 2019
Signed-off-by: John Plevyak <jplevyak@gmail.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Mirrors: envoyproxy/envoy-mobile#288 Adds converters to go from Request to a set of headers that upstream Envoy understands. This will be utilized by the request logic in the Envoy class. For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: kotlin: add conversion from Request to headers Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Mirrors: envoyproxy/envoy-mobile#288 Adds converters to go from Request to a set of headers that upstream Envoy understands. This will be utilized by the request logic in the Envoy class. For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: kotlin: add conversion from Request to headers Risk Level: low Testing: unit Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This refactors the extproc package and eliminates all context.Background usages. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** This eliminates context.Background in config loading code path. **Related Issues/PRs (if applicable)** This is a follow up on #296 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.