ecds: support for upstream network filter#29240
Merged
htuch merged 12 commits intoenvoyproxy:mainfrom Aug 30, 2023
Merged
Conversation
Signed-off-by: ohadvano <ohadvano@gmail.com>
Signed-off-by: ohadvano <ohadvano@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
Author
|
/assign @kyessenov |
Signed-off-by: ohadvano <ohadvano@gmail.com>
kyessenov
reviewed
Aug 24, 2023
kyessenov
reviewed
Aug 24, 2023
Contributor
kyessenov
left a comment
There was a problem hiding this comment.
I haven't checked the tests fully, but overall LGTM.
Signed-off-by: ohadvano <ohadvano@gmail.com>
Contributor
Author
|
/assign @htuch |
Contributor
Author
|
ping @htuch |
htuch
suggested changes
Aug 29, 2023
Signed-off-by: ohadvano <ohadvano@gmail.com>
htuch
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Description: Support of upstream network filter with ECDS. Resolves #14696.
Risk Level: low
Testing: Integration tests
Docs Changes: ECDS docs
Release Notes: None
Platform Specific Features: None