deps: Update protbuf to v23.1 by yanavlasov · Pull Request #28075 · envoyproxy/envoy

yanavlasov · 2023-06-21T19:45:47Z

New patches:

PGV to work with handling of new C++20 keywords added in protobuf (upstreaming change to PGV now)
absl patch to exclude stack symbolization for WASM modules. The implementation is buggy and causes existing WASM filter tests to fail. This is being fixed in emscripten SDK and absl env.emscripten_stack_snapshot not available in STANDALONE emscripten-core/emscripten#19753
Compilation issues in protobuf. Fixed on protbuf main, waiting for a new version to be cut

Breaking changes:

Substitution formatter of the filter dynamic metadata no longer supports NaN and Inf floating point numbers, producing an error messages instead of JSON object of the proto. This is deemed to be an edge case.

Fixed a bunch of change detector tests that relied on specific error messages emitted by the previous version of the protobuf JSON parser.

Some dependencies are not at the bleeding edge versions, but this PR brings Envoy code over the biggest hump and allows to upgrade to newer version with smaller changes later.

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #27757

repokitteh-read-only · 2023-06-21T19:45:54Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #28075 was opened by yanavlasov.

see: more, trace.

phlax · 2023-06-21T19:55:09Z

patch looks good, thanks for working on this!

yanavlasov · 2023-06-22T15:01:51Z

Slow progress. Many dependencies are broken. Actively working on it.

phlax · 2023-06-22T15:29:23Z

possibly related protocolbuffers/protobuf#12523

(EDIT: probs not actually - i was trying to see what was going on with python headers)

phlax · 2023-06-22T18:27:28Z

re the python_headers im not sure we still need to alias them - but if we do i believe we can use

diff --git a/bazel/repositories.bzl b/bazel/repositories.bzl
index fd13e73479..ac50ff6276 100644
--- a/bazel/repositories.bzl
+++ b/bazel/repositories.bzl
@@ -894,7 +894,7 @@ def _com_google_protobuf():
     # https://github.com/google/protobuf/blob/v3.6.1/util/python/BUILD#L6-L9
     native.bind(
         name = "python_headers",
-        actual = "@com_google_protobuf//util/python:python_headers",
+        actual = "@system_python//:python_headers",
     )
 
 def _io_opencensus_cpp():

yanavlasov · 2023-06-22T20:02:57Z

There is still a ton of test failures due to a change to the error messages in protobuf JSON parser.

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov · 2023-06-23T14:57:59Z

Still about 15 tests are failing. Mobile build is broken for unknown reason. @RyanTheOptimist

Signed-off-by: Yan Avlasov <yavlasov@google.com>

repokitteh-read-only · 2023-07-04T23:54:14Z

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #28075 was synchronize by yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com>

alyssawilk · 2023-07-10T13:16:48Z

Looks like this one is stalled. Did we decide to merge now or wait for release? If we're waiting let's tag it as such just to keep it off the daily on-call spam, and if not let's merge today to max out production time :-)

phlax

lgtm, thanks @yanavlasov

phlax · 2023-07-10T16:33:31Z

per offline discussion, landing

Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>

phlax · 2023-07-11T20:23:08Z

/coverage

repokitteh-read-only · 2023-07-11T20:23:13Z

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/28075/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

🐱

Caused by: a #28075 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>

Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: yanavlasov <yavlasov@google.com>

keith · 2024-05-24T01:32:58Z

it doesn't look like this pgv patch ever made it upstream, sent it here bufbuild/protoc-gen-validate#1110

Porting this from envoyproxy/envoy#28075

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 21, 2023

repokitteh-read-only bot assigned mattklein123 Jun 21, 2023

yanavlasov marked this pull request as draft June 21, 2023 19:46

yanavlasov unassigned mattklein123 Jun 21, 2023

phlax mentioned this pull request Jun 22, 2023

deps: update cel-cpp to 2023-05-19 #27967

Closed

yanavlasov force-pushed the protobuf-update branch 2 times, most recently from c050d13 to e950871 Compare June 22, 2023 15:01

yanavlasov force-pushed the protobuf-update branch 3 times, most recently from 358f8e9 to 8725ec6 Compare June 22, 2023 18:19

yanavlasov force-pushed the protobuf-update branch from 8725ec6 to 3c1fea5 Compare June 22, 2023 19:58

yanavlasov force-pushed the protobuf-update branch from 3c1fea5 to 6bbba1b Compare June 23, 2023 13:30

Update protobuf to v23.1

b11dd38

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov force-pushed the protobuf-update branch from 6bbba1b to b11dd38 Compare June 23, 2023 14:14

Fix more tests

8efc61a

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov added 7 commits June 26, 2023 19:05

Fix more change detector tests

4515d88

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Undo mobile override of protobuf version

e818d3b

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Fix //test/tools/router_check/test:router_tool_test

d3035be

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Fix //test/common/formatter:substitution_formatter_test

bdc4566

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Try to fix mobile build

f42a404

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Fix //test/common/stream_info:stream_info_impl_test in optimized build

558fa52

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Fix //test/tools/router_check/test:router_tool_test

f33b4ed

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov mentioned this pull request Jun 28, 2023

Allow Envoy Mobile to build with Lite Protos #28016

Merged

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jun 30, 2023

RyanTheOptimist previously approved these changes Jun 30, 2023

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 30, 2023

Fix clang-tidy error

9e7a8ca

Signed-off-by: Yan Avlasov <yavlasov@google.com>

yanavlasov dismissed RyanTheOptimist’s stale review via 9e7a8ca July 1, 2023 11:59

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jul 1, 2023

Address comments and coverage

2f46d0c

Signed-off-by: Yan Avlasov <yavlasov@google.com>

Fix format

89d65a9

Signed-off-by: Yan Avlasov <yavlasov@google.com>

phlax approved these changes Jul 10, 2023

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 10, 2023

phlax merged commit 65273b2 into envoyproxy:main Jul 10, 2023

yanavlasov deleted the protobuf-update branch July 10, 2023 17:27

ericvn mentioned this pull request Jul 10, 2023

Automator: update envoy@ in istio/proxy@master istio/proxy#4794

Closed

reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023

deps: Update protbuf to v23.1 (envoyproxy#28075)

918685a

Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>

sumitd2 pushed a commit to sumitd2/envoy that referenced this pull request Jul 12, 2023

deps: Update protbuf to v23.1 (envoyproxy#28075)

d7c7b5d

Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>

chipmunkie mentioned this pull request Jul 14, 2023

Temporarily disable coverage_integration test. envoyproxy/nighthawk#1005

Merged

adisuissa mentioned this pull request Jul 14, 2023

grpc-patch: fix for oss-fuzz build #28409

Merged

chipmunkie mentioned this pull request Jul 14, 2023

coverage_integration test binary size too large after protobuf update to v23.1 envoyproxy/nighthawk#1006

Open

phlax pushed a commit to phlax/envoy that referenced this pull request Oct 9, 2023

deps: Update protbuf to v23.1 (envoyproxy#28075)

3d4696f

Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: yanavlasov <yavlasov@google.com>

keith mentioned this pull request May 24, 2024

Add handling for C++20 keywords bufbuild/protoc-gen-validate#1110

Merged

rodaine pushed a commit to bufbuild/protoc-gen-validate that referenced this pull request May 24, 2024

Add handling for C++20 keywords (#1110)

ca115cf

Porting this from envoyproxy/envoy#28075

Conversation

yanavlasov commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Jun 21, 2023

Uh oh!

phlax commented Jun 21, 2023

Uh oh!

yanavlasov commented Jun 22, 2023

Uh oh!

phlax commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phlax commented Jun 22, 2023

Uh oh!

yanavlasov commented Jun 22, 2023

Uh oh!

yanavlasov commented Jun 23, 2023

Uh oh!

repokitteh-read-only bot commented Jul 4, 2023

Uh oh!

alyssawilk commented Jul 10, 2023

Uh oh!

phlax left a comment

Choose a reason for hiding this comment

Uh oh!

phlax commented Jul 10, 2023

Uh oh!

phlax commented Jul 11, 2023

Uh oh!

repokitteh-read-only bot commented Jul 11, 2023

Uh oh!

keith commented May 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yanavlasov commented Jun 21, 2023 •

edited

Loading

phlax commented Jun 22, 2023 •

edited

Loading