RLQS: Improve the test coverage#28022
Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom Jun 20, 2023
Merged
Conversation
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Member
Author
|
/retest |
Member
Author
|
/assign @yanavlasov @alyssawilk PTAL Thanks! |
yanavlasov
approved these changes
Jun 20, 2023
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
* remove untested code for now Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: asheryer <asheryer@amazon.com>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
* remove untested code for now Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve test coverage by : add a test case for data_unavailable/MatchState::UnableToMatch and remove untested code.
Fix: #24353