As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

@moderation @ramaraochavali FYI

This seemed to pass //test/... on my dev box. @moderation suggested there was an incompatibility but I didn't see it in our tests so far. Maybe CI will be more thorough.

/retest

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

/retest

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

This PR, as it is, only changes the metadata and doesn't include the latest commit. Try

    com_github_circonus_labs_libcircllhist = dict(
        project_name = "libcircllhist",
        project_desc = "An implementation of OpenHistogram log-linear histograms",
        project_url = "https://github.com/openhistogram/libcircllhist",
        version = "95f8f6b089fc4e8dc215ed903221f9f55d4813b3",
        sha256 = "0712445bec6ab71a2ad386f96b3e8fd8777ecaf5264f144e49236ea343fc2e96",
        strip_prefix = "libcircllhist-{version}",
        urls = ["https://github.com/circonus-labs/libcircllhist/archive/{version}.tar.gz"],
        use_category = ["controlplane", "observability_core", "dataplane_core"],
        release_date = "2022-12-15",
        cpe = "N/A",
        license = "Apache-2.0",
        license_url = "https://github.com/openhistogram/libcircllhist/blob/{version}/LICENSE",
    ),

In my testing that will cause tests for histograms to fail

alright this is blossoming into its own project :)

external/com_github_circonus_labs_libcircllhist/src/circllhist.c:34:10: fatal error: 'cdflib.h' file not found
#include "cdflib.h"
         ^~~~~~~~~~
1 error generated.

I'm flipping this back to draft mode.

@pradeepcrao was working on this upgrade at some point.

Yeah I thought so. I'm going to pause working on this; I don't want to pick up this dependency hacking stuff. I was looking to see if we could upgrade to a slightly more recent libcirclhist but not one that added the cdflib dependency.

Yeah I thought so. I'm going to pause working on this; I don't want to pick up this dependency hacking stuff. I was looking to see if we could upgrade to a slightly more recent libcirclhist but not one that added the cdflib dependency.

Do we just need to update the BUILD file ? https://github.com/envoyproxy/envoy/blob/main/bazel/external/libcircllhist.BUILD#L5

I can take a stab at this today.

@pradeepcrao I think you are right. I testing a couple of months ago I think I got this compiling with those changes. But then the histogram tests started failing and I bailed

Pradeep if you are set with this I'll close this PR and defer to you

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!