bazel: fix protobuf UBSAN errors#2452
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jan 25, 2018
brian-pane:ubsan-fix
Merged
bazel: fix protobuf UBSAN errors#2452mattklein123 merged 1 commit intoenvoyproxy:masterfrom brian-pane:ubsan-fix
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
brian-pane:ubsan-fix
Conversation
*Description*: The google-protobuf library, by default, uses unaligned reads on x86. Those happen to work on that CPU architecture, but their behavior is undefined in C/C++, so UBSAN (which runs along with ASAN in the CI ASAN tests) treats them as an error. Defining `ADDRESS_SANITIZER=1` causes the protobuf library to use a portable alternative to the unaligned reads. Signed-off-by: Brian Pane <bpane@pinterest.com> *Risk Level*: Low *Testing*: I tested this change with PR [2429](#2429), where it fixed the ASAN test failure. *Docs Changes*: N/A *Release Notes*: N/A
mattklein123
approved these changes
Jan 25, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
envoyproxy#2452) * Use FilterState instead of DynamicMetadata in Metadata Exchange Plugin Also made the plugin in sync with existing HTTP Metadata Exchange Wasm Plugin, so that stats(prometheus) plugin can use this easily. Fixed based on feedback * Fix build errors
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
Continued from #2441. Description: Parallels Android implementation based on SharedPreferences. Risk Level: Low Testing: Application Co-authored-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Continued from #2441. Description: Parallels Android implementation based on SharedPreferences. Risk Level: Low Testing: Application Co-authored-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The google-protobuf library, by default, uses unaligned reads on x86.
Those happen to work on that CPU architecture, but their behavior is
undefined in C/C++, so UBSAN (which runs along with ASAN in the CI
ASAN tests) treats them as an error.
Defining
ADDRESS_SANITIZER=1causes the protobuf library to usea portable alternative to the unaligned reads.
Risk Level: Low
Testing: I tested this change with PR 2429, where it fixed the ASAN test failure.
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Brian Pane bpane@pinterest.com