ci: allowed to create users with duplicate in run_envoy_docker script#2448
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 24, 2018
Merged
ci: allowed to create users with duplicate in run_envoy_docker script#2448htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Gabriel <gsagula@gmail.com>
Member
Author
|
@htuch Whenever you get a chance. Thanks! |
htuch
approved these changes
Jan 24, 2018
Member
|
Thanks, appreciate testing on both Linux and OS X for this one. |
Member
Author
|
Np. I got my old VM up and running :) |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes #2379 (Linux) by passing --non-unique to docker command. This option allows creating duplicated users.
Risk Level: Low
Testing: manual OSx, Linux
Signed-off-by: Gabriel gsagula@gmail.com