Rollback #22036 due to crash#24475
Merged
KBaichoo merged 2 commits intoenvoyproxy:mainfrom Dec 10, 2022
Merged
Conversation
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
Please see https://github.com/envoyproxy/envoy/pull/22036/files#r1044579979 for the rollback reason. |
Contributor
|
@LuyaoZhong please add nullptr check and tests that validate this condition. |
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
This was referenced Dec 11, 2022
LuyaoZhong
pushed a commit
to LuyaoZhong/envoy
that referenced
this pull request
Dec 11, 2022
Envoy supports selecting certs by selecting filter chain based on SNI. But it is possible that we access different services via one filter chain, which requires SNI-based cert selection in one single filter chain during handshake. This change is merged by envoyproxy#22036 and reverted by envoyproxy#24475. Signed-off-by: Luyao Zhong <luyao.zhong@intel.com>
ggreenway
pushed a commit
that referenced
this pull request
Dec 14, 2022
Envoy supports selecting certs by selecting filter chain based on SNI. But it is possible that we access different services via one filter chain, which requires SNI-based cert selection in one single filter chain during handshake. This change is merged by #22036 and reverted by #24475. Signed-off-by: Luyao Zhong <luyao.zhong@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message: Rollback #22036 due to crash
Additional Description: See #22036 (comment)
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features: