ci: print stack traces on UBSAN errors in the ASAN CI build#2447
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 24, 2018
brian-pane:ubsan-backtrace
Merged
ci: print stack traces on UBSAN errors in the ASAN CI build#2447htuch merged 1 commit intoenvoyproxy:masterfrom brian-pane:ubsan-backtrace
htuch merged 1 commit intoenvoyproxy:masterfrom
brian-pane:ubsan-backtrace
Conversation
Signed-off-by: Brian Pane <bpane@pinterest.com>
htuch
approved these changes
Jan 24, 2018
| --verbose_failures ${BAZEL_OPTIONS} --action_env=HOME --action_env=PYTHONUSERBASE \ | ||
| --jobs=${NUM_CPUS} --show_task_finish ${BAZEL_BUILD_EXTRA_OPTIONS}" | ||
| export BAZEL_TEST_OPTIONS="${BAZEL_BUILD_OPTIONS} --test_env=HOME --test_env=PYTHONUSERBASE \ | ||
| --test_env=UBSAN_OPTIONS=print_stacktrace=1 \ |
Member
There was a problem hiding this comment.
This could optionally be made local to the ASAN/UBSAN invocation, but looking at docs (https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html) it seems harmless to do it here as well.
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: GitHub Action <noreply@github.com> Co-authored-by: jpsim <jpsim@users.noreply.github.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: GitHub Action <noreply@github.com> Co-authored-by: jpsim <jpsim@users.noreply.github.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
UBSAN doesn't show stack traces by default, so this diff adds the environment variable
needed to enable stack traces.
Risk Level: Low
Testing: The CircleCI ASAN run will exercise this code change.
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Brian Pane bpane@pinterest.com