Skip to content

test_coverage: fix posix test coverage#24463

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
tyxia:coverage
Dec 9, 2022
Merged

test_coverage: fix posix test coverage#24463
phlax merged 1 commit intoenvoyproxy:mainfrom
tyxia:coverage

Conversation

@tyxia
Copy link
Copy Markdown
Member

@tyxia tyxia commented Dec 9, 2022

Coverage test is now failing with message Code coverage for source/common/common/posix is lower than limit of 94.5 (92.7). Change it back to 92.7 which is the original coverage limits.

Signed-off-by: tyxia tyxia@google.com

Signed-off-by: tyxia <tyxia@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24463 was opened by tyxia.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk

🐱

Caused by: #24463 was opened by tyxia.

see: more, trace.

@tyxia tyxia marked this pull request as ready for review December 9, 2022 02:55
@tyxia
Copy link
Copy Markdown
Member Author

tyxia commented Dec 9, 2022

/assign @RyanTheOptimist

Add Ryan as well in case Alyssa is OOO.

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tyxia im gonna land this unbreak CI, lgtm

@phlax phlax merged commit c865e79 into envoyproxy:main Dec 9, 2022
@tyxia tyxia deleted the coverage branch December 9, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants