build: remove custom xcode flags for boringssl#2445
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 24, 2018
Merged
Conversation
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
htuch
approved these changes
Jan 24, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* update envoy-wasm * update date * change vm to runtime * add config * update sha
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Makes these more readable, and easier to validate. Risk Level: Low Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Makes these more readable, and easier to validate. Risk Level: Low Testing: CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
One of the BoringSSL updates we've picked up in the last few months fixed the need for extra flags when compiling BoringSSL in Xcode 9.
Risk Level: Low
Testing: existing CI is sufficient
Release Notes: N/A
Signed-off-by: Stephan Zuercher stephan@turbinelabs.io