Remove unecessary this-> usages in mobile/...engine_builder.cc#24385
Closed
caschoener wants to merge 0 commit intoenvoyproxy:mainfrom
Closed
Remove unecessary this-> usages in mobile/...engine_builder.cc#24385caschoener wants to merge 0 commit intoenvoyproxy:mainfrom
this-> usages in mobile/...engine_builder.cc#24385caschoener wants to merge 0 commit intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/mobile-maintainers: FYI only for changes made to |
RyanTheOptimist
previously approved these changes
Dec 6, 2022
Contributor
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Thank you for doing this!
Contributor
|
Looks like it needs the format to be fixed, though. |
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason this file uses
this->to reference class members. Let's ctrl-f to remove them all!Tests work with all usages removed.