lds: expose lds metadata through factory context#2435
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Jan 25, 2018
Merged
lds: expose lds metadata through factory context#2435mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Matt Rice <mattrice@google.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM. Can you check ASAN failure?
Member
Author
|
Yep, taking a look now. |
Member
Author
|
I think this issue will be fixed when #2443 goes in, so I'll wait on that. |
Signed-off-by: Matt Rice <mattrice@google.com>
mattklein123
approved these changes
Jan 25, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* Add trust domain and trust domain aliases to mTLS API * Merge trust domain and trust domain aliases * Add more comment
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Also update rules_apple and rules_java Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Also update rules_apple and rules_java Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adds a
listenerMetadata()method inFactoryContextto expose the lds metadata to filters and access logs. See #1278.Risk Level: Low
Testing: Added a unit test to ensure the processing and getter in
ListenerImplwork as expected.Docs Changes: envoyproxy/data-plane-api#430
Release Notes: N/A