config: avoid spurious empty final discovery request.#2432
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 23, 2018
Merged
config: avoid spurious empty final discovery request.#2432htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
When a subscription is for the empty set, rather than a specific set of services, avoid sending an empty request when the watch ends. Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Jan 23, 2018
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: The change is needed in order for JNI to be able to find classes which are defined in our repository (as opposed to built in Java types). Google documents in here touches on this issue. The implementation could be improved by adding some caching to it but I am inclined to keep it simple unless we find out that its performance is an issue. Needed for #2432. Risk Level: None, not used anywhere as of now. Testing: Manual Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: The change is needed in order for JNI to be able to find classes which are defined in our repository (as opposed to built in Java types). Google documents in here touches on this issue. The implementation could be improved by adding some caching to it but I am inclined to keep it simple unless we find out that its performance is an issue. Needed for #2432. Risk Level: None, not used anywhere as of now. Testing: Manual Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subscription is for the empty set, rather than a specific set of services, avoid sending an
empty request when the watch ends.
Testing: UT
Risk Level: Low
Signed-off-by: Harvey Tuch htuch@google.com