mobile: add CircleCI docs generation CI job#24295
Conversation
This is the CI job that's responsible for building the public website docs at https://envoymobile.io. Signed-off-by: JP Simard <jp@jpsim.com>
|
@alyssawilk do you think you could set up the CircleCI webhook here, mirroring the one defined in Envoy Mobile? https://github.com/envoyproxy/envoy-mobile/settings/hooks/246245000 |
|
Ideally we'll migrate this to GitHub Actions, but I'd like to get it up and running as it's defined in Envoy Mobile first. |
i was wondering about this - the way we currently publish Envoy docs is with GCS - this is also what lets us use iiuc this set up requires using azp (cc @lizan for confirmation on this) so im wondering whether it makes sense to use that for this job specifically |
|
Theoretically I've done the webhook so my high level question is do we want to limit the work to only pull requests containing mobile files or changes to circileci as we did with all the yaml? |
ok I'll push an empty commit to hopefully trigger it.
I'm inclined to build on every change for now, the job is reliable in my experience, and pretty fast, finishing in ~2 minutes: https://app.circleci.com/pipelines/github/envoyproxy/envoy-mobile/12852/workflows/98b67571-3236-4b62-aac7-f20c9696f584/jobs/13177 |
Signed-off-by: JP Simard <jp@jpsim.com>
56f1de8 to
1a60dd2
Compare
|
SG. from the UI I think we need to land this before I can configure it on app.circleci.com so want lmk if you want to merge as is or have me point to your branch first to test |
If it's possible to point to this branch so we can validate this before we merge, that'd be great. |
.circleci/config.yml
Outdated
| - run: mobile/docs/build.sh | ||
| - add_ssh_keys: | ||
| fingerprints: | ||
| - "a2:f7:59:f0:01:8b:91:31:ab:0c:3f:9f:25:4c:1e:e5" |
There was a problem hiding this comment.
this is one of the few things that differed per project so not sure if it'll work but I'm fine landing and seeing :-P
There was a problem hiding this comment.
Presumably this means publishing won't work.
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
|
CC @envoyproxy/mobile-maintainers: FYI only for changes made to |
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
|
Docs were successfully pushed in envoy-mobile/envoy-mobile.github.io@9f451fb |
Signed-off-by: JP Simard <jp@jpsim.com>
This is the CI job that's responsible for building the public website docs at https://envoymobile.io.
Commit Message: mobile: add CircleCI docs generation CI job
Additional Description: This is the CI job that's responsible for building the public website docs at https://envoymobile.io.
Risk Level: Low
Testing: In Envoy Mobile repo.
Docs Changes: Yes :)
Release Notes: None.
Platform Specific Features: Only relevant to mobile.
Part of #23758