take stat_lock during SharedMemoryHashSet construction, since it reads shared-memory#2424
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Jan 22, 2018
Merged
Conversation
…s sanityCheck(), which reads the data model fully. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM, small typo, thanks
source/server/hot_restart_impl.cc
Outdated
| log_lock_(shmem_.log_lock_), access_log_lock_(shmem_.access_log_lock_), | ||
| stat_lock_(shmem_.stat_lock_), init_lock_(shmem_.init_lock_) { | ||
| { | ||
| // We must hold the stat lock when attaching to an existing shared-memorh segment |
mattklein123
approved these changes
Jan 22, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* jwt: extract claim with whitespce as list * fix format
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Add an arm64 run configuration for Envoy example app so that it's possible to run and debug Envoy Mobile example app on ARM machines (i.e., M1 Macbooks). Following steps from https://envoy-mobile.github.io/docs/envoy-mobile/latest/development/debugging/android_local.html#adding-envoy-mobile-project-into-android-studio it's possible to set up an Android project that makes it possible to run and debug Envoy Mobile example app (put symbolic breakpoints in Envoy code). As it is now, the configured/added run configuration supports running of x86 builds only which do not work on ARM machines. Risk Level: None Testing: Run new configuration locally on M1 Macbook. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Add an arm64 run configuration for Envoy example app so that it's possible to run and debug Envoy Mobile example app on ARM machines (i.e., M1 Macbooks). Following steps from https://envoy-mobile.github.io/docs/envoy-mobile/latest/development/debugging/android_local.html#adding-envoy-mobile-project-into-android-studio it's possible to set up an Android project that makes it possible to run and debug Envoy Mobile example app (put symbolic breakpoints in Envoy code). As it is now, the configured/added run configuration supports running of x86 builds only which do not work on ARM machines. Risk Level: None Testing: Run new configuration locally on M1 Macbook. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During construction, when attaching to an already-existing shared-memory segment, we call sanityCheck(), which reads the data model fully. So we need to hold a lock.
Signed-off-by: Joshua Marantz jmarantz@google.com
Description:
Hold the SharedMemoryHashSet in a std::unique_ptr in HotRestartImpl because it needs to take a lock during construction. We do this by moving the construction of the SharedMemoryHashSet from HotRestartImpl's initializer-list to the constructor body, holding the lock during construction.
Risk Level: Low
Testing:
//test/...