Skip to content

lightstep: fix string temporary issue#2405

Merged
mattklein123 merged 1 commit intomasterfrom
fix_lightstep
Jan 18, 2018
Merged

lightstep: fix string temporary issue#2405
mattklein123 merged 1 commit intomasterfrom
fix_lightstep

Conversation

@mattklein123
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 commented Jan 18, 2018

Regression from #2368

Risk Level: Low
Testing: Covered by existing tests (why ASAN does not catch I don't know)
Docs Changes: N/A
Release Notes: N/A

@mattklein123
lightstep: fix string temporary issue
452dcae 
Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Copy Markdown
Member Author

mattklein123 commented Jan 18, 2018

@moderation @gsagula

@moderation
Copy link
Copy Markdown
Contributor

moderation commented Jan 18, 2018

Confirmed the patch worked for me on both Linux Xubuntu 17.10 and MacOS. Traces now being sent to Lightstep.

gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/c++/4.2.1
Apple LLVM version 9.0.0 (clang-900.0.39.2)
Target: x86_64-apple-darwin17.3.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

@mattklein123 mattklein123 merged commit 8784428 into master Jan 18, 2018
@mattklein123 mattklein123 deleted the fix_lightstep branch January 18, 2018 23:35
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Mar 28, 2020
@bianpengyuan @istio-testing
Update destination service label (envoyproxy#2405)
8cb4a1c 
* update label name to destination.service.name

* update test yaml
jpsim added a commit that referenced this pull request Nov 28, 2022
@jpsim
bazel: update rules_xcodeproj to 0.5.0 (#2405)
7ec18aa 
https://github.com/buildbuddy-io/rules_xcodeproj/releases/tag/0.5.0

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request Nov 29, 2022
@jpsim
bazel: update rules_xcodeproj to 0.5.0 (#2405)
b142061 
https://github.com/buildbuddy-io/rules_xcodeproj/releases/tag/0.5.0

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danielhochman danielhochman danielhochman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattklein123 @moderation @danielhochman