Fixing a (downstream) msan failure#2403
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jan 18, 2018
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Jan 18, 2018
ggreenway
approved these changes
Jan 18, 2018
htuch
approved these changes
Jan 18, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: GitHub Action <noreply@github.com> Co-authored-by: jpsim <jpsim@users.noreply.github.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: GitHub Action <noreply@github.com> Co-authored-by: jpsim <jpsim@users.noreply.github.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the structure of shared memory is
[100 options slots][control struct] and we try parse it as [99 options][control struct] we end up parsing the control struct from the uninitialized options memory. Fixed via memset.
Risk Level: n/a (test fix)
Testing: exactly.
Release Notes: n/a