codeql: Bump clang versions#23926
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Nov 10, 2022
Merged
Conversation
Fixes envoyproxy#23580 Full diff: google/tcmalloc@5940033...e33c7bc Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Member
Author
|
this hasnt triggered a codeql run - ill try and run a test to trigger elsewhere |
Member
Author
|
great, that seems to have worked https://github.com/envoyproxy/envoy/actions/runs/3436724618/jobs/5730585103 |
alyssawilk
approved these changes
Nov 10, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome, thanks for tracking this down!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also rebumps tcmalloc and adds comments about keeping clang versions in sync
Fix #23891
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]