Merged
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
htuch
approved these changes
Jan 16, 2018
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Platform specific CI jobs that run mobile applications have their timeouts set to 25 minutes. This is not enough to build Envoy Mobile itself and the apps that are used to verify that EM works as expected. Make CI jobs (that have timeouts equal to 25 minutes) depend on the 'main' CI job that's supposed to build Envoy Mobile binary and has a timeout of 90 minutes. This way, when platform specific CI jobs start they can reuse the cache that's populated by the CI job with timeout equal to 90 minutes. Risk Level: N/A Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Platform specific CI jobs that run mobile applications have their timeouts set to 25 minutes. This is not enough to build Envoy Mobile itself and the apps that are used to verify that EM works as expected. Make CI jobs (that have timeouts equal to 25 minutes) depend on the 'main' CI job that's supposed to build Envoy Mobile binary and has a timeout of 90 minutes. This way, when platform specific CI jobs start they can reuse the cache that's populated by the CI job with timeout equal to 90 minutes. Risk Level: N/A Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.