Skip to content

bazel: fix more config_setting visibility#23709

Merged
keith merged 1 commit intoenvoyproxy:mainfrom
keith:ks/bazel-fix-more-config_setting-visibility
Oct 28, 2022
Merged

bazel: fix more config_setting visibility#23709
keith merged 1 commit intoenvoyproxy:mainfrom
keith:ks/bazel-fix-more-config_setting-visibility

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Oct 27, 2022

Fixes #23390

This is an edge case, upstream issue: bazelbuild/bazel-skylib#404

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

Fixes envoyproxy#23390

This is an edge case, upstream issue: bazelbuild/bazel-skylib#404

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith enabled auto-merge (squash) October 27, 2022 16:17
@keith
Copy link
Copy Markdown
Member Author

keith commented Oct 27, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23709 (comment) was created by @keith.

see: more, trace.

@keith keith merged commit b3e59bd into envoyproxy:main Oct 28, 2022
@keith keith deleted the ks/bazel-fix-more-config_setting-visibility branch October 28, 2022 20:04
jwendell pushed a commit to jwendell/envoy that referenced this pull request Dec 22, 2022
Fixes envoyproxy#23390

This is an edge case, upstream issue: bazelbuild/bazel-skylib#404

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visibility failure on Bazel 6.0

2 participants