Skip to content

backport: ocsp: rotate certs of test data to fix flaky tests (#23635)#23641

Merged
phlax merged 1 commit intoenvoyproxy:release/v1.23from
wbpcode:dev-backport-1.23-certs-update
Oct 25, 2022
Merged

backport: ocsp: rotate certs of test data to fix flaky tests (#23635)#23641
phlax merged 1 commit intoenvoyproxy:release/v1.23from
wbpcode:dev-backport-1.23-certs-update

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented Oct 24, 2022

Commit Message: backport: ocsp: rotate certs of test data to fix flaky tests (#23635)
Additional Description:

See #23635

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

* ocsp: rotate certs of test data

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

* fix format

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented Oct 24, 2022

cc @phlax

@wbpcode
Copy link
Copy Markdown
Member Author

wbpcode commented Oct 24, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23641 (comment) was created by @wbpcode.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 24, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23641 (comment) was created by @phlax.

see: more, trace.

@phlax phlax self-assigned this Oct 24, 2022
@phlax phlax added this to the 1.23.3 milestone Oct 24, 2022
@dio
Copy link
Copy Markdown
Member

dio commented Oct 24, 2022

Cool. Thanks, @wbpcode!

@dio
Copy link
Copy Markdown
Member

dio commented Oct 24, 2022

This is required to unblock: #23639.

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @wbpcode

@phlax phlax merged commit 0fb8620 into envoyproxy:release/v1.23 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants