Skip to content

backport: tools, github: Add current SOURCE_VERSION writer#23639

Merged
phlax merged 3 commits intoenvoyproxy:release/v1.23from
dio:write-source-version-1.23
Oct 25, 2022
Merged

backport: tools, github: Add current SOURCE_VERSION writer#23639
phlax merged 3 commits intoenvoyproxy:release/v1.23from
dio:write-source-version-1.23

Conversation

@dio
Copy link
Copy Markdown
Member

@dio dio commented Oct 24, 2022

Commit Message: This adds a script to write the current SOURCE_VERSION.

Cherry-picked from:

Signed-off-by: Dhi Aurrahman dio@rockybars.com

Additional Description: To provide the script inside the source code tarball for each release version. The next tag will have this, but even before I can use the merged patch to get it, without curl-ing directly from https://raw.githubusercontent.com.
Risk Level: N/A
Testing: Manual
Docs Changes: Updated.
Release Notes: N/A
Platform-Specific Features: N/A

@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 24, 2022

/assign @phlax

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @dio

@phlax phlax enabled auto-merge (squash) October 24, 2022 11:00
@phlax phlax added this to the 1.23.3 milestone Oct 24, 2022
@wbpcode
Copy link
Copy Markdown
Member

wbpcode commented Oct 24, 2022

Please merge the main to fix the flaky ci.

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 24, 2022

Please merge the main to fix the flaky ci.

this is a backport - i think ci is just flaky on that branch

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23639 (comment) was created by @phlax.

see: more, trace.

@wbpcode
Copy link
Copy Markdown
Member

wbpcode commented Oct 24, 2022

cc @phlax The ci is flaky because the certs of ocsp are expired. So, maybe we should backport the certs refresh first. 🤣

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 24, 2022

ah - yep - i see - yep, lets backport the cert update

@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 24, 2022

Depends on #23641.

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 25, 2022

@dio do you want to merge - ci should be good now

@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 25, 2022

Thanks, @phlax!

@phlax phlax enabled auto-merge (squash) October 25, 2022 10:38
@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 25, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23639 (comment) was created by @dio.

see: more, trace.

@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 25, 2022

Not sure why bazel.coverage takes forever to run :(.

@phlax phlax merged commit eef9bed into envoyproxy:release/v1.23 Oct 25, 2022
@dio dio deleted the write-source-version-1.23 branch October 25, 2022 22:51
@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 25, 2022

Thanks for merging, @phlax!

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 26, 2022

Not sure why bazel.coverage takes forever to run :(.

to do with caching or rather not caching i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants