access log: fix integration test flake#2333
Merged
mattklein123 merged 1 commit intomasterfrom Jan 9, 2018
Merged
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
zuercher
approved these changes
Jan 9, 2018
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
And validate that it builds successfully on CI. Ideally we'd have a whole suite of example integrations that validate all our supported installation methods, but this should be a good start. I reached out to the owner of https://catfacts.ninja to make sure this usage is within the terms of service and will update to use something else if necessary. https://user-images.githubusercontent.com/474794/171312056-2167333a-fb88-4cfe-aa30-353cceaa49a0.mp4 Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
And validate that it builds successfully on CI. Ideally we'd have a whole suite of example integrations that validate all our supported installation methods, but this should be a good start. I reached out to the owner of https://catfacts.ninja to make sure this usage is within the terms of service and will update to use something else if necessary. https://user-images.githubusercontent.com/474794/171312056-2167333a-fb88-4cfe-aa30-353cceaa49a0.mp4 Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: None
Testing: Test fix
Docs Changes: N/A
Release Notes: N/A
Fixes #2327