contributing: DCO fixup best practice.#2279
Conversation
Signed-off-by: Harvey Tuch <htuch@google.com>
| your history: | ||
|
|
||
| ```bash | ||
| git rebase -i HEAD^^ |
There was a problem hiding this comment.
FWIW, this is what I have been telling people who are new to get. The only reason I think this is better is it will work with any number of commits and doesn't require interactive. Thoughts?
git fetch
git rebase origin/master
git reset origin/master
git commit -as
git push origin -f
The only thing I don't know about is I don't typically work in a fork. For people on a fork, is it still origin/master? Or something else?
Thoughts?
There was a problem hiding this comment.
I have upstream/master for the fork. I think in general, it's hard to give a perfect config agnostic setup, since you might name the remote foo and it would be foo/master.
I agree a soft reset is probably more direct. There's two reasons I didn't advice to do it here:
-
It's awesome to learn about the Swiss army knife of interactive rebase if you are new to git, it opens up lots of options later.
-
The flow you describe is adding a
origin/masterrebase, which may be desired, but is technically not needed.
I don't mind if you want to recommend that instead, just giving the motivation I had in mind.
There was a problem hiding this comment.
Nah it's fine, just throwing it out there.
There was a problem hiding this comment.
OK, let's see if folks find what I put in simple enough. If not, we can improve in a followup PR.
mattklein123
left a comment
There was a problem hiding this comment.
awesome, thanks for adding this
* Pulls in #21277 to unblock further progress on multi-engine support * Updates Docker build image to the same version used in Envoy * Updates LLVM to 14.0.0 * Updates Python to 3.10 Diff: efbbb04...d88f31b Signed-off-by: JP Simard <jp@jpsim.com>
* Pulls in #21277 to unblock further progress on multi-engine support * Updates Docker build image to the same version used in Envoy * Updates LLVM to 14.0.0 * Updates Python to 3.10 Diff: efbbb04...d88f31b Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Harvey Tuch htuch@google.com