Skip to content

contributing: DCO fixup best practice.#2279

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:dco-hacks
Dec 29, 2017
Merged

contributing: DCO fixup best practice.#2279
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:dco-hacks

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Dec 29, 2017

Signed-off-by: Harvey Tuch htuch@google.com

Signed-off-by: Harvey Tuch <htuch@google.com>
your history:

```bash
git rebase -i HEAD^^
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is what I have been telling people who are new to get. The only reason I think this is better is it will work with any number of commits and doesn't require interactive. Thoughts?

git fetch
git rebase origin/master
git reset origin/master
git commit -as
git push origin -f

The only thing I don't know about is I don't typically work in a fork. For people on a fork, is it still origin/master? Or something else?

Thoughts?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have upstream/master for the fork. I think in general, it's hard to give a perfect config agnostic setup, since you might name the remote foo and it would be foo/master.

I agree a soft reset is probably more direct. There's two reasons I didn't advice to do it here:

  1. It's awesome to learn about the Swiss army knife of interactive rebase if you are new to git, it opens up lots of options later.

  2. The flow you describe is adding a origin/master rebase, which may be desired, but is technically not needed.

I don't mind if you want to recommend that instead, just giving the motivation I had in mind.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah it's fine, just throwing it out there.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's see if folks find what I put in simple enough. If not, we can improve in a followup PR.

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for adding this

@htuch htuch merged commit 52c6a17 into envoyproxy:master Dec 29, 2017
@htuch htuch deleted the dco-hacks branch December 29, 2017 02:55
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Mar 28, 2020
jpsim added a commit that referenced this pull request Nov 28, 2022
* Pulls in #21277 to unblock further progress on multi-engine support
* Updates Docker build image to the same version used in Envoy
* Updates LLVM to 14.0.0
* Updates Python to 3.10

Diff: efbbb04...d88f31b

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request Nov 29, 2022
* Pulls in #21277 to unblock further progress on multi-engine support
* Updates Docker build image to the same version used in Envoy
* Updates LLVM to 14.0.0
* Updates Python to 3.10

Diff: efbbb04...d88f31b

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants