router: update all http filters to get per filter config by the http filter config name at first#22002
Conversation
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/wait CI |
|
@soulxu could you take a look as a first pass when you have free time? Thanks. |
soulxu
left a comment
There was a problem hiding this comment.
LGTM except one comment about duplicated test.
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
…se-new-method-for-route-config
|
cc @markdroth could you take a look when you have free time for this doc only API changes? Thanks. |
|
cc @mattklein123 @kyessenov I think this is also ready for a second pass. Could you take a look? Thanks. |
mattklein123
left a comment
There was a problem hiding this comment.
Nice this is great. LGTM with a small comment. Thank you.
/wait
| // The key should match the `filter config name | ||
| // <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpFilter.name>`. |
There was a problem hiding this comment.
Please ref link using :ref: (same elsewhere)
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Commit Message: router: update all http filters to get per filter config by the http filter config name
Additional Description:
Further work of #21525. Last step to close #12274.
Risk Level: Mid.
Testing: Updated.
Docs Changes: n/a.
Release Notes: Added.
Platform Specific Features: n/a.