docs: add more extension type URLs#21885
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/21885/docs/index.html The docs are (re-)rendered each time the CI |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
htuch
left a comment
There was a problem hiding this comment.
Looks good, couple of questions.
| public: | ||
| // Envoy::Http::StatefulHeaderKeyFormatterFactoryConfig | ||
| std::string name() const override { return "preserve_case"; } | ||
| std::string name() const override { |
There was a problem hiding this comment.
Is there something that can systematically done to style check these names in presubmit?
There was a problem hiding this comment.
We can add name validation to test/exe/check_extensions_against_registry_test.cc. There are a lot of exceptions already so not sure how to only apply to new extensions.
There was a problem hiding this comment.
OK, just a suggestion for making this more defensible, I'll merge.
|
/lgtm api-v2-freeze |
|
no relevant owners for "api-v2-freeze" |
|
/lgtm v2-freeze |
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Kuat Yessenov kuat@google.com
Commit Message: Follow-up to #21707 with a focus on back-filling more extension type URLs. Renames
extensions_build_configandextensions_metadatato the names in the internal extension registry. Forpreserve_case, we deprecate the short name with the fully qualified name (both names are valid in the interim).Risk Level: medium, only
preserve_casename changesTesting: regression
Docs Changes: yes
Release Notes: yes